Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cgreen based unit tests for gvmd #579

Merged
merged 13 commits into from
Jun 14, 2019

Conversation

mattmundell
Copy link
Contributor

@mattmundell mattmundell commented Jun 4, 2019

Exploring Cgreen as an option for gvmd unit tests.

@mattmundell mattmundell changed the title Unit tests cgreen CGreen based unit tests for gvmd Jun 4, 2019
@mattmundell mattmundell changed the title CGreen based unit tests for gvmd Cgreen based unit tests for gvmd Jun 4, 2019
@bjoernricks
Copy link
Contributor

👍 👍 👍 really nice!

mattmundell and others added 9 commits June 4, 2019 14:07
This adds a test for create_ticket_run, which is complex because
create_ticket_run calls into other parts of the gvmd code (copy_ticket,
ticket_uuid, log_event, etc).

The test creates 'mock' versions of those functions.

A gcc attribute is used as an easy way to override the mocked functions.
The alternative would be to link against less of the gvmd code and to
fill the gaps with stub functions.  But our code is not very cleanly
separated to this is a lot of work.  Should get easier as we clean
things up, if the attribute is not suitable.
This test requires a system function to be wrapped, and specifies the
return of the system function in the test (which is more usefull than
specifying it in the wrapper).
@mattmundell mattmundell marked this pull request as ready for review June 10, 2019 15:49
@mattmundell mattmundell requested a review from a team June 10, 2019 15:49
Copy link
Member

@timopollmeier timopollmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me gmp-tickets-test fails with a segmentation fault.
See the comment in src/gmp_tickets_tests.c for what I found with a quick gdb stack trace.

src/gmp_tickets_tests.c Show resolved Hide resolved
@mattmundell mattmundell merged commit 65ad517 into greenbone:master Jun 14, 2019
@mattmundell mattmundell deleted the unit-tests-cgreen branch June 14, 2019 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants