-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cgreen based unit tests for gvmd #579
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattmundell
changed the title
CGreen based unit tests for gvmd
Cgreen based unit tests for gvmd
Jun 4, 2019
👍 👍 👍 really nice! |
This adds a test for create_ticket_run, which is complex because create_ticket_run calls into other parts of the gvmd code (copy_ticket, ticket_uuid, log_event, etc). The test creates 'mock' versions of those functions. A gcc attribute is used as an easy way to override the mocked functions. The alternative would be to link against less of the gvmd code and to fill the gaps with stub functions. But our code is not very cleanly separated to this is a lot of work. Should get easier as we clean things up, if the attribute is not suitable.
This test requires a system function to be wrapped, and specifies the return of the system function in the test (which is more usefull than specifying it in the wrapper).
timopollmeier
requested changes
Jun 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me gmp-tickets-test fails with a segmentation fault.
See the comment in src/gmp_tickets_tests.c for what I found with a quick gdb stack trace.
timopollmeier
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploring Cgreen as an option for gvmd unit tests.